[Merged by Bors] - ci: Update the workflow so the chain doesn’t get skipped when upload_cache is skipped#35389
Closed
marcelolynch wants to merge 2 commits intoleanprover-community:masterfrom
Closed
Conversation
PR summary 3bbc5c706cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
added
the
CI
Contributor
|
bors try |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…cache is skipped (#35389)
Contributor
tryBuild failed: |
Updated post-CI job condition to ensure it runs only if direct dependencies succeeded.
Contributor
|
bors try |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…cache is skipped (#35389) Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Contributor
Contributor
Contributor
|
Thanks: let's get this moving! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…cache is skipped (#35389) Currently some PRs sent to `bors` have ended up failing (#35330, #34667) because the upload_cache step was skipped, causing the required Post-Build and Post-CI jobs to get skipped as well. This PR adjusts the conditionals to ensure that those steps still run even if the cache upload gets skipped. Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
kim-em
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 17, 2026
…cache is skipped (leanprover-community#35389) Currently some PRs sent to `bors` have ended up failing (leanprover-community#35330, leanprover-community#34667) because the upload_cache step was skipped, causing the required Post-Build and Post-CI jobs to get skipped as well. This PR adjusts the conditionals to ensure that those steps still run even if the cache upload gets skipped. Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
kim-em
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Feb 17, 2026
…cache is skipped (leanprover-community#35389) Currently some PRs sent to `bors` have ended up failing (leanprover-community#35330, leanprover-community#34667) because the upload_cache step was skipped, causing the required Post-Build and Post-CI jobs to get skipped as well. This PR adjusts the conditionals to ensure that those steps still run even if the cache upload gets skipped. Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently some PRs sent to
borshave ended up failing (#35330, #34667) because the upload_cache step was skipped, causing the required Post-Build and Post-CI jobs to get skipped as well. This PR adjusts the conditionals to ensure that those steps still run even if the cache upload gets skipped.